♻️ Towards a common long_running_tasks interface #7833
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7833 +/- ##
==========================================
- Coverage 87.89% 86.37% -1.52%
==========================================
Files 1836 1444 -392
Lines 70999 60423 -10576
Branches 1219 618 -601
==========================================
- Hits 62402 52190 -10212
+ Misses 8254 8033 -221
+ Partials 343 200 -143
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
GitHK
changed the title
GitHK
requested review from
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
giancarloromeo
left a comment
giancarloromeo
left a comment
There was a problem hiding this comment.
Good. What about having a single interface for these "long running tasks", Celery ones and any other future implementation?
I'm trying to move in this direction, currently I'm tying to unify the aiohttp and fastapi versions of this code. |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 4777c9e |
|
4 participants
What do these changes do?
NOTE: PR is very noisy, but functionally nothing changed.
I'm trying to make the
long_running_tasksmore resilient. These will be of great help in the future and move in the direction of the restorability milestone.This is the second in a series of PRs.
Here I am merely centralising the imports from the common library in servicelib.
In future PRs I will also make sure the interfaces are the same by inheriting form a common one.
Related issue/s
How to test
Dev-ops